Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seal_ prefixes from FFI #1482

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Remove seal_ prefixes from FFI #1482

merged 6 commits into from
Nov 11, 2022

Conversation

agryaznov
Copy link
Contributor

Follow-up to substrate#11444

@athei
Copy link
Contributor

athei commented Nov 9, 2022

From the CI:

ERROR: An unexpected import function was found in the contract Wasm: get_storage

I think we need a fix for cargo contract which expects that imports start with seal_.

@ascjones ascjones mentioned this pull request Nov 10, 2022
Merged
@ascjones
Copy link
Collaborator

From the CI:

ERROR: An unexpected import function was found in the contract Wasm: get_storage

I think we need a fix for cargo contract which expects that imports start with seal_.

use-ink/cargo-contract#816

@ascjones ascjones merged commit e883ce5 into master Nov 11, 2022
@ascjones ascjones deleted the ag-remove-seal branch November 11, 2022 09:43
@ascjones ascjones mentioned this pull request Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agryaznov @athei @ascjones