Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add merge/rebase response; fix crashing app on wrong argument in root #240

Merged
merged 1 commit into from
Sep 11, 2023
Merged

add merge/rebase response; fix crashing app on wrong argument in root #240

merged 1 commit into from
Sep 11, 2023

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Sep 8, 2023

add merge/rebase response; fix crashing app on wrong argument in root
image

I'm curious how long do they store these assets in GitHub?

@mordamax mordamax requested a review from a team as a code owner September 8, 2023 21:23
@rzadp
Copy link
Contributor

rzadp commented Sep 11, 2023

I'm curious how long do they store these assets in GitHub?

Good question. Here we have a similar link and it seems to stay up for months, but not sure how long it's gonna last.

If we want to be sure it works for years, we should maybe store it in the repo and point to it like here.

@mordamax
Copy link
Contributor Author

mordamax commented Sep 11, 2023 •
edited
Loading

I'm curious how long do they store these assets in GitHub?

Good question. Here we have a similar link and it seems to stay up for months, but not sure how long it's gonna last.

If we want to be sure it works for years, we should maybe store it in the repo and point to it like here.

I never seen yet the github comments with broken image.. and comments with images store for years.
But tbh - i didn't think to store this for years, as it's just helper for migration. At some soon point it will be safe to just remove this helper

@mordamax mordamax merged commit 57b8b08 into master Sep 11, 2023
8 checks passed
@mordamax mordamax deleted the mak-fix-crashing-app-and-add-instructions branch September 11, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bullrich Bullrich Bullrich approved these changes

@rzadp rzadp rzadp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mordamax @rzadp @Bullrich