This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Trivial networking changes for Substrate PR #11940 #1486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really nice. Good spot.
…te-11940 # Conflicts: # client/relay-chain-inprocess-interface/Cargo.toml # test/service/Cargo.toml # test/service/src/lib.rs
arkpar
approved these changes
Aug 9, 2022
Merge cancelled due to error. Error: Statuses failed for b57ae3e |
bkchr
added
B0-silent
Changes should not be mentioned in any release notes
C1-low 📌
labels
Aug 9, 2022
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 4553858 |
pepoviola
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Trivial networking changes for Substrate PR paritytech/substrate#11940 * Apply formatting rules * update lockfile for {"polkadot", "substrate"} Co-authored-by: parity-processbot <>
bkchr
pushed a commit
that referenced
this pull request
Aug 18, 2022
* changes to read json spec in test binary * add zombienet tests * fmt * use {{COL_IMAGE}} and clean config * add comment and use relay image from env * use test-parachain image from pr * fix warns * fix warns * fmt * typo * fix ci to use zombienet image * fix spawn nodes for test * reorg test * add within to test * remove check for full node collators is up * add tests for pov, mirate solo to para, sync blocks * bump zombienet image * add job dep with artifacts * add sleep for test * fix after merge * fmt * bump zombienet version * changes from clap * use base/shared params * fmt * debug ci * add upgrade test * update js test for debug * less debug in test * print assertion * fix upgrade test * Collator key only needed if we run as collator * [Fix] Benchmark build artifact folder creation (#1518) * Trivial networking changes for Substrate PR #11940 (#1486) * Trivial networking changes for Substrate PR paritytech/substrate#11940 * Apply formatting rules * update lockfile for {"polkadot", "substrate"} Co-authored-by: parity-processbot <> * bump zombienet version * update network def for test * typo Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#11940