Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

introduce RelaychainStateProvider to parachain-system #2268

Merged
merged 6 commits into from
Mar 5, 2023
Merged

introduce RelaychainStateProvider to parachain-system #2268

merged 6 commits into from
Mar 5, 2023

Conversation

seunlanlege
Copy link
Contributor

This will allow parachains to read the relay chain state via storage proofs.

@bkchr
Copy link
Member

bkchr commented Mar 3, 2023

You can just use validation_data() in your pallets. I don't see the reason for this trait. It is not that you will have any other source in your parachain that can return these values.

@seunlanlege
Copy link
Contributor Author

seunlanlege commented Mar 3, 2023 •
edited
Loading

You can just use validation_data() in your pallets. I don't see the reason for this trait. It is not that you will have any other source in your parachain that can return these values.

I think we should prefer loose coupling over tight coupling here, so pallets are immune to the implementation details of parachain-system and however it may change over time.

bkchr
bkchr approved these changes Mar 3, 2023
View reviewed changes
pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/state-proof-based-parachain-parachain-messaging/2214/1

seunlanlege and others added 3 commits March 5, 2023 00:01
@seunlanlege @joepetrowski @bkchr
Apply suggestions from code review
f274187 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
@seunlanlege
deprecation message
ae23a2f
@seunlanlege
Merge branch 'master' of github.com:polytope-labs/cumulus
3b17411
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes labels Mar 5, 2023
@bkchr bkchr merged commit 349e7e8 into paritytech:master Mar 5, 2023
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joepetrowski joepetrowski joepetrowski left review comments

@rphmeier rphmeier rphmeier approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seunlanlege @bkchr @Polkadot-Forum @rphmeier @joepetrowski