This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
T0-node
This PR/Issue is related to the topic “node”.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Mar 14, 2023
davxy
approved these changes
Mar 14, 2023
|
||
### Zombienet | ||
We use Zombienet to spin up networks for integration tests and local networks. Follow [these installation steps](https://github.com/paritytech/zombienet#requirements-by-provider) to set it up on your machine. | ||
A simple network specification with two relay chain nodes and one collator is located at [zombienet/examples/small_network.toml](zombienet/examples/small_network.toml). | ||
We use Zombienet to spin up networks for integration tests and local networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
We use Zombienet to spin up networks for integration tests and local networks. | |
Zombienet is used to spin up networks for integration tests and local networks. |
A simple network specification with two relay chain nodes and one collator is located at [zombienet/examples/small_network.toml](zombienet/examples/small_network.toml). | ||
We use Zombienet to spin up networks for integration tests and local networks. | ||
Follow [these installation steps](https://github.com/paritytech/zombienet#requirements-by-provider) | ||
to set it up on your machine. A simple network specification with two relay chain nodes and one collator is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
to set it up on your machine. A simple network specification with two relay chain nodes and one collator is | |
to set it up on local machine. A simple network specification with two relay chain nodes and one collator is |
michalkucharczyk
approved these changes
Mar 14, 2023
minor: Matter of taste, I prefer impersonal forms in tech specs. |
ordian
added a commit
that referenced
this pull request
Mar 16, 2023
* master: (44 commits) Companion for #13287 (#2155) timestamp ci job logs (#2327) Release parachain host API v4 (#2325) Bump clap from 4.1.6 to 4.1.8 (#2272) Enabled `polkadot-parachain` build for `runtime-benchmarks`, e.g.: (#2324) Bump tokio from 1.25.0 to 1.26.0 (#2273) Bump async-trait from 0.1.64 to 0.1.66 (#2318) ReadMe followup for #2313 (#2317) Fix runtime api import path (#2319) Update Westend collectives chainspec (#2311) README: Document usage of RPC node (#2313) Companion for paritytech/substrate#13592 (#2310) Update orchestra and metered-channel (#2304) Backport: Brigehub: Add in force upgrade xcm version (into master) (#2289) [Backport] version bumps from 9380 (#2309) Bump proc-macro2 from 1.0.50 to 1.0.52 (#2312) Remove use of trait Store (#2286) Companion for #13482 (#2303) add amforc bootnodes (#2246) Cleanup dependencies + dead code (#2302) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T0-node
This PR/Issue is related to the topic “node”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments did not make it in time in #2313.