XCM V2 weight template #2344

ggwpez · 2023-03-17T18:44:09Z

Update the weight template to correctly produce proof weights and dont use deprecated functions anymore.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Legally not needed, we already remove them from Substrate. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-03-17T18:44:18Z

bot help

ggwpez · 2023-03-17T18:50:11Z

bot bench $ xcm statemine asset pallet_xcm_benchmarks::fungible

ggwpez · 2023-03-17T18:52:14Z

bot bench $ xcm statemine asset pallet_xcm_benchmarks::fungible

…m_benchmarks::fungible

parachains/runtimes/asset/statemine/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs

ggwpez · 2023-03-19T14:20:36Z

bot bench $ xcm statemine assets pallet_xcm_benchmarks::fungible

…cm_benchmarks::fungible

ggwpez · 2023-03-19T16:17:05Z

bot bench $ xcm statemint assets pallet_xcm_benchmarks::fungible
bot bench $ xcm statemint assets pallet_xcm_benchmarks::generic
bot bench $ xcm statemine assets pallet_xcm_benchmarks::generic

…cm_benchmarks::fungible

…cm_benchmarks::generic

…allet_xcm_benchmarks::fungible" This reverts commit c4ac1a8. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-03-20T13:42:41Z

bot bench $ xcm westmint assets pallet_xcm_benchmarks::generic
bot bench $ xcm westmint assets pallet_xcm_benchmarks::fungible
bot clean

…m_benchmarks::generic

…m_benchmarks::fungible

ggwpez · 2023-03-20T16:07:25Z

bot help

ggwpez · 2023-03-20T16:08:43Z

bot bench $ xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::generic

…hubs pallet_xcm_benchmarks::generic

bkontur

@ggwpez
cool, looks good, is it done or ianything else missing? I see just weight for all bridge-hub runtimes are not completed

bkontur · 2023-03-23T10:06:18Z

bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::fungibles
bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::generic
bot bench $ xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::fungibles
bot bench $ xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::fungibles

EgorPopelyaev · 2023-03-23T10:23:39Z

@ggwpez Hey Oliver, is there any timeline for this PR? Looks like this one is needed for the upcoming .40 cumulus release

bkontur · 2023-03-23T11:06:47Z

bot bench $ xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::fungible
bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::fungible
bot bench $ xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::fungible

ggwpez · 2023-03-23T11:07:19Z

bot cancel
bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::fungible
bot bench $ xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::fungible
bot bench $ xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::fungible

ggwpez · 2023-03-23T11:08:11Z

@ggwpez Hey Oliver, is there any timeline for this PR? Looks like this one is needed for the upcoming .40 cumulus release

Yea sorry. Having my fun with the bot 😅 Should complete in ~3 hrs.

bkontur · 2023-03-23T11:08:32Z

bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::generic

mordamax · 2023-03-23T12:04:04Z

bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::generic

mordamax · 2023-03-23T12:04:28Z

bot bench $ xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::generic

Done directly on bm2 to bypass the bot. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-03-23T12:13:35Z

bot cancel
bot clean

Updated manually on bm2.

ggwpez · 2023-03-23T12:35:29Z

bot merge

paritytech-processbot · 2023-03-23T12:35:37Z

Waiting for commit status.

* Update XCM weight template Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove copyright year from file header Legally not needed, we already remove them from Substrate. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::generic * Revert "".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible" This reverts commit c4ac1a8. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::generic * Update weights Done directly on bm2 to bypass the bot. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

* Update XCM weight template * Remove copyright year from file header Legally not needed, we already remove them from Substrate. * ".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::generic * Revert "".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible" This reverts commit c4ac1a8. * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::generic * Update weights Done directly on bm2 to bypass the bot. --------- Co-authored-by: command-bot <> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* master: Add Support for Foreign Assets (#2133) XCM V2 weight template (#2344) Companion for polkadot#6928 (#2356) move back to ci-linux@production image

* Update XCM weight template * Remove copyright year from file header Legally not needed, we already remove them from Substrate. * ".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::generic * Revert "".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible" This reverts commit c4ac1a8. * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::generic * Update weights Done directly on bm2 to bypass the bot. --------- Co-authored-by: command-bot <> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* XCM V2 weight template (#2344) (#2372) * Update XCM weight template * Remove copyright year from file header Legally not needed, we already remove them from Substrate. * ".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_xcm_benchmarks::generic * Revert "".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xcm_benchmarks::fungible" This reverts commit c4ac1a8. * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::generic * ".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-polkadot bridge-hubs pallet_xcm_benchmarks::generic * Update weights Done directly on bm2 to bypass the bot. --------- Co-authored-by: command-bot <> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * [benchmarks] pr with weights (#2373) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> * [benchmarks] pr with weights (#2374) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> * [benchmarks] pr with weights (#2375) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Paritytech CI <52199148+paritytech-ci@users.noreply.github.com> Co-authored-by: paritytech-ci <paritytech-ci@parity.io>

ggwpez added 2 commits March 17, 2023 19:41

Update XCM weight template

e1be803

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Remove copyright year from file header

628a4b6

Legally not needed, we already remove them from Substrate. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez marked this pull request as draft March 17, 2023 18:44

".git/.scripts/commands/bench/bench.sh" xcm statemine asset pallet_xc…

c4ac1a8

…m_benchmarks::fungible

ggwpez commented Mar 18, 2023

View reviewed changes

parachains/runtimes/asset/statemine/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs Outdated Show resolved Hide resolved

command-bot added 2 commits March 19, 2023 14:20

Merge branch 'master' of https://github.com/paritytech/cumulus into HEAD

85544d3

".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_x…

f7a89a8

…cm_benchmarks::fungible

command-bot and others added 4 commits March 19, 2023 17:26

".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_x…

c33042a

…cm_benchmarks::fungible

".git/.scripts/commands/bench/bench.sh" xcm statemint assets pallet_x…

0e2c498

…cm_benchmarks::generic

".git/.scripts/commands/bench/bench.sh" xcm statemine assets pallet_x…

bb5f740

…cm_benchmarks::generic

Revert "".git/.scripts/commands/bench/bench.sh" xcm statemine asset p…

bab3f9e

…allet_xcm_benchmarks::fungible" This reverts commit c4ac1a8. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

command-bot added 4 commits March 20, 2023 13:42

Merge branch 'master' of https://github.com/paritytech/cumulus into HEAD

2a10337

".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xc…

2861bec

…m_benchmarks::generic

Merge branch 'master' of https://github.com/paritytech/cumulus into HEAD

df9cb94

".git/.scripts/commands/bench/bench.sh" xcm westmint assets pallet_xc…

72df1e2

…m_benchmarks::fungible

command-bot added 2 commits March 20, 2023 16:08

Merge branch 'master' of https://github.com/paritytech/cumulus into HEAD

2b6d91c

".git/.scripts/commands/bench/bench.sh" xcm bridge-hub-kusama bridge-…

e45c0fc

…hubs pallet_xcm_benchmarks::generic

bkontur mentioned this pull request Mar 21, 2023

BridgeHubs: XCM ExportMessage benchmark - just Rococo for now #2353

Closed

bkontur approved these changes Mar 23, 2023

View reviewed changes

Update weights

1d10f8f

Done directly on bm2 to bypass the bot. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez marked this pull request as ready for review March 23, 2023 12:13

ggwpez requested a review from EgorPopelyaev March 23, 2023 12:14

paritytech deleted a comment from command-bot bot Mar 23, 2023

EgorPopelyaev approved these changes Mar 23, 2023

View reviewed changes

paritytech-processbot bot merged commit 9f2b54e into master Mar 23, 2023

paritytech-processbot bot deleted the oty-xcm-weight-template branch March 23, 2023 12:45

EgorPopelyaev mentioned this pull request Mar 23, 2023

[Backport] XCM V2 weight template (#2344) to release branch #2372

Merged

ordian added a commit that referenced this pull request Mar 23, 2023

Merge branch 'master' into ao-past-session-slashing-companion

e9327cd

* master: Add Support for Foreign Assets (#2133) XCM V2 weight template (#2344) Companion for polkadot#6928 (#2356) move back to ci-linux@production image

mordamax mentioned this pull request Mar 23, 2023

Bug: sometimes gitlab api fails with ValidationError: "id" is required paritytech/command-bot#166

Closed

hbulgarini mentioned this pull request May 10, 2023

[0.9.40] Weights v2 - Include WeightToFee on XCM Trader paritytech/trappist#168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XCM V2 weight template #2344

XCM V2 weight template #2344

ggwpez commented Mar 17, 2023 •

edited

Loading

ggwpez commented Mar 17, 2023

ggwpez commented Mar 17, 2023

ggwpez commented Mar 17, 2023

ggwpez commented Mar 19, 2023

ggwpez commented Mar 19, 2023

ggwpez commented Mar 20, 2023

ggwpez commented Mar 20, 2023

ggwpez commented Mar 20, 2023

bkontur left a comment

bkontur commented Mar 23, 2023

EgorPopelyaev commented Mar 23, 2023

bkontur commented Mar 23, 2023

ggwpez commented Mar 23, 2023

ggwpez commented Mar 23, 2023

bkontur commented Mar 23, 2023

mordamax commented Mar 23, 2023

mordamax commented Mar 23, 2023

ggwpez commented Mar 23, 2023 •

edited

Loading

ggwpez commented Mar 23, 2023

paritytech-processbot bot commented Mar 23, 2023

XCM V2 weight template #2344

XCM V2 weight template #2344

Conversation

ggwpez commented Mar 17, 2023 • edited Loading

ggwpez commented Mar 17, 2023

ggwpez commented Mar 17, 2023

ggwpez commented Mar 17, 2023

ggwpez commented Mar 19, 2023

ggwpez commented Mar 19, 2023

ggwpez commented Mar 20, 2023

ggwpez commented Mar 20, 2023

ggwpez commented Mar 20, 2023

bkontur left a comment

Choose a reason for hiding this comment

bkontur commented Mar 23, 2023

EgorPopelyaev commented Mar 23, 2023

bkontur commented Mar 23, 2023

ggwpez commented Mar 23, 2023

ggwpez commented Mar 23, 2023

bkontur commented Mar 23, 2023

mordamax commented Mar 23, 2023

mordamax commented Mar 23, 2023

ggwpez commented Mar 23, 2023 • edited Loading

ggwpez commented Mar 23, 2023

paritytech-processbot bot commented Mar 23, 2023

ggwpez commented Mar 17, 2023 •

edited

Loading

ggwpez commented Mar 23, 2023 •

edited

Loading