This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Companion for polkadot#7234 (XCM: Tools for uniquely referencing messages) #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
B1-note_worthy
Changes should be noted in the release notes
C1-low
PR touches the given topic and has a low impact on builders.
D9-needsaudit 👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
T1-runtime
This PR/Issue is related to the topic “runtime”.
labels
May 19, 2023
11 tasks
gavofyork
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
May 19, 2023
bkontur
approved these changes
May 23, 2023
@gavofyork
could this be fixed now with this new message_id/topic stuff? wdyt? |
These changes don't much help this. In fact, the functions inside |
bkchr
approved these changes
May 25, 2023
ordian
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval stamp to unblock the companion check
sam0x17
approved these changes
May 25, 2023
This was referenced Jul 31, 2023
redzsina
added
D1-audited 👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited.
and removed
D9-needsaudit 👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B1-note_worthy
Changes should be noted in the release notes
C1-low
PR touches the given topic and has a low impact on builders.
D1-audited 👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited.
T1-runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to fix for new API. Also moves
DenyThenTry
andDenyReserveTransferToRelayChain
into Polkadot.This revamps some of the *MPQ events to correctly report both the message hash and ID. It also moves the *MPQ code over to use
ExecuteXcm::prepare_and_execute
rather than the older APIs, which required simplifying some tests since the new API is at a slightly lower level.