Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add sudo to template node #2748

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Add sudo to template node #2748

merged 5 commits into from
Jun 19, 2023

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier commented Jun 16, 2023

To make the template node work out of the box.

Many new developers have complained about not being able to perform a runtime upgrade.

Unfortunately, there is no sudo or democracy available for this task.

Therefore, I have added the sudo in this PR.

@gilescope gilescope requested a review from HCastano June 16, 2023 12:38
@gilescope
Copy link
Contributor

Could you put the sudo pallet as 15 please? There's an extended parachain template that people are developing (not yet done, so not yet public), and they're using 15 for sudo. I think it's a good idea to add sudo - many parachains start off with it before migrating to more decentralised governance structures...

@gilescope gilescope added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 18, 2023
@gilescope
Copy link
Contributor

Benchmarks are complaining about sudo but it has benchmarks these days... paritytech/substrate#13880 so not sure why it's complaining?

Co-authored-by: Squirrel <giles@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Jun 18, 2023

Benchmarks are complaining about sudo but it has benchmarks these days... paritytech/substrate#13880 so not sure why it's complaining?

Could be that the runtime-benchmarks feature is missing in the runtime Cargo.toml.

@gilescope gilescope added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 19, 2023
@gilescope
Copy link
Contributor

@AurevoirXavier in parachain-template/runtime/Cargo.toml can you add "pallet-sudo/runtime-benchmarks", under the runtime-benchmarks feature please?

@gilescope
Copy link
Contributor

bot merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants