This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
use PolkadotXcm for XcmRouter WrapVersion #674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
reviewed
Oct 18, 2021
| @@ -595,7 +595,7 @@ pub type LocalOriginToLocation = (); | |||
| /// queues. | |||
| pub type XcmRouter = ( | |||
| // Two routers - use UMP to communicate with the relay chain: | |||
| cumulus_primitives_utility::ParentAsUmp<ParachainSystem, ()>, | |||
| cumulus_primitives_utility::ParentAsUmp<ParachainSystem, PolkadotXcm>, | |||
There was a problem hiding this comment.
I suspect it's because the relay chain hasn't been upgraded to a version that supported version negotiation before, and neither did statemine include the XCM pallet. Now if those two conditions are fulfilled, there's no reason not to use it.
Deferring to @gavofyork for final approval.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any reason why this isn't used?