This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for substrate#9732 #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
approved these changes
Oct 21, 2021
bkchr
reviewed
Dec 21, 2021
| @@ -21,21 +21,26 @@ use sp_runtime::traits::{Block as BlockT, Hash as HashT, Header as HeaderT, Zero | |||
| /// Generate the genesis block from a given ChainSpec. | |||
| pub fn generate_genesis_block<Block: BlockT>( | |||
| chain_spec: &Box<dyn ChainSpec>, | |||
| genesis_state_version: sp_runtime::StateVersion, | |||
There was a problem hiding this comment.
Can we not fetch the runtime version from the code in the genesis state? As we do this in Substrate?
There was a problem hiding this comment.
That was my first idea, but current code need an executor (for compatibility I think), so ends up being really easier to use this way.
You think it is a must have, or can we keep it this way (seems only use from commands at this point)?
There was a problem hiding this comment.
Hmm, this is not really future proof.
| @@ -60,6 +60,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| impl_version: 0, | |||
| apis: RUNTIME_API_VERSIONS, | |||
| transaction_version: 1, | |||
| state_version: 1, | |||
There was a problem hiding this comment.
Suggested change
| state_version: 1, | |
| state_version: 0, |
Probably too late.
bkchr
approved these changes
Dec 24, 2021
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 05e0861 |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 7869bae |
|
bot merge |
26 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion for paritytech/substrate#9732