-
Notifications
You must be signed in to change notification settings - Fork 378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Thank you!
Could we maybe also add a sample script/some usage docs somewhere in the repo?
Have you seen https://paritytech.github.io/substrate/master/try_runtime_cli/enum.Command.html and https://paritytech.github.io/substrate/master/try_runtime_cli/index.html? |
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
I believe we're in good shape now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bkchr @paritytech/ci are you okay with the CI changes? |
} | ||
impl_benchmark_test_suite!(Pallet, crate::mock::new_test_ext(), crate::mock::Test, extra = false,); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could never work and was not compiling in the first place either, because the mock
of pallet_session
cannot be used here.
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Parachain teams can now use this to (somewhat) easily test their migrations (or other shenanigans) of live chains using the cumulus client.
Example:
Also needed by @apopiak for runtime upgrade testing of Statemine (and Statemint in the future).
Also needed for paritytech/substrate#10073
--features try-runtime
as well.