Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Integrate try-runtime into cumulus #793

Merged
merged 18 commits into from
Dec 2, 2021
Merged

Integrate try-runtime into cumulus #793

merged 18 commits into from
Dec 2, 2021

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Nov 24, 2021

Parachain teams can now use this to (somewhat) easily test their migrations (or other shenanigans) of live chains using the cumulus client.

Example:

cargo remote -d nightly -b "RUST_LOG=remote-ext=debug,runtime=trace" run -- --features try-runtime --bin polkadot-collator -- try-runtime --chain=statemine-dev on-runtime-upgrade live --uri wss://kusama-statemine-rpc.paritytech.net:443

# or 

RUST_LOG=remote-ext=debug,runtime=trace cargo run --features try-runtime --bin polkadot-collator -- try-runtime --chain=statemine-dev on-runtime-upgrade live --uri wss://kusama-statemine-rpc.paritytech.net:443

Also needed by @apopiak for runtime upgrade testing of Statemine (and Statemint in the future).
Also needed for paritytech/substrate#10073

  • Make sure the cumulus CI runs --features try-runtime as well.

polkadot-parachains/Cargo.toml Outdated Show resolved Hide resolved
polkadot-parachains/parachains-common/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
Thank you!
Could we maybe also add a sample script/some usage docs somewhere in the repo?

polkadot-parachains/src/command.rs Show resolved Hide resolved
parachain-template/node/Cargo.toml Outdated Show resolved Hide resolved
parachain-template/runtime/src/lib.rs Show resolved Hide resolved
@kianenigma kianenigma requested a review from a team as a code owner November 30, 2021 08:45
parachain-template/node/Cargo.toml Outdated Show resolved Hide resolved
@kianenigma
Copy link
Contributor Author

kianenigma commented Nov 30, 2021

❤️ Thank you! Could we maybe also add a sample script/some usage docs somewhere in the repo?

Have you seen https://paritytech.github.io/substrate/master/try_runtime_cli/enum.Command.html and https://paritytech.github.io/substrate/master/try_runtime_cli/index.html?

kianenigma and others added 3 commits November 30, 2021 12:03
@kianenigma
Copy link
Contributor Author

I believe we're in good shape now.

Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kianenigma
Copy link
Contributor Author

@bkchr @paritytech/ci are you okay with the CI changes?

}
impl_benchmark_test_suite!(Pallet, crate::mock::new_test_ext(), crate::mock::Test, extra = false,);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could never work and was not compiling in the first place either, because the mock of pallet_session cannot be used here.

parachain-template/node/src/command.rs Outdated Show resolved Hide resolved
parachain-template/runtime/Cargo.toml Outdated Show resolved Hide resolved
polkadot-parachains/src/command.rs Outdated Show resolved Hide resolved
kianenigma and others added 3 commits December 2, 2021 13:00
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants