Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no-skip flag #12

Merged
merged 4 commits into from
May 3, 2023
Merged

feat: no-skip flag #12

merged 4 commits into from
May 3, 2023

Conversation

harrysolovay
Copy link
Contributor

@harrysolovay harrysolovay commented Apr 21, 2023 •
edited
Loading

I often use egts locally and would like to disable the (useful-for-speeding-CI) @test_skip directive. This PR introduces an unskip boolean flag.

- deno run -A https://deno.land/x/egts@v0.1.0/test.ts 'examples/**/*.eg.ts'
+ deno run -A https://deno.land/x/egts@v0.1.0/test.ts --no-skip 'examples/**/*.eg.ts'

tjjfvi
tjjfvi reviewed Apr 22, 2023
View reviewed changes
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps --no-skip instead of --unskip?

@harrysolovay harrysolovay changed the title feat: unskip flag feat: no-skip flag Apr 25, 2023
tjjfvi
tjjfvi reviewed Apr 25, 2023
View reviewed changes
words.txt Outdated Show resolved Hide resolved
harrysolovay
harrysolovay commented Apr 25, 2023
View reviewed changes
words.txt Outdated Show resolved Hide resolved
tjjfvi
tjjfvi reviewed Apr 28, 2023
View reviewed changes
test.ts Outdated Show resolved Hide resolved
harrysolovay
harrysolovay commented May 2, 2023
View reviewed changes
test.ts Show resolved Hide resolved
@harrysolovay harrysolovay requested review from tjjfvi and removed request for tjjfvi May 2, 2023 13:58
@harrysolovay harrysolovay merged commit 56fde66 into main May 3, 2023
@harrysolovay harrysolovay deleted the unskip branch May 3, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjjfvi tjjfvi tjjfvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrysolovay @tjjfvi