Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to polkadot-v1.0.0 #15

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Upgrade to polkadot-v1.0.0 #15

merged 2 commits into from
Aug 30, 2023

Conversation

Moliholy
Copy link
Contributor

No description provided.

@Moliholy Moliholy requested a review from stiiifff August 18, 2023 15:51
@Moliholy Moliholy self-assigned this Aug 18, 2023
@Moliholy Moliholy requested a review from weezy20 August 18, 2023 15:56
@Moliholy
Copy link
Contributor Author

@weezy20 the CI didn't trigger. Any idea why?

@weezy20
Copy link
Contributor

weezy20 commented Aug 18, 2023

@Moliholy

Yeah the current work flow does not trigger on opened PRs. That's a todo that will be shortly resolved.

@weezy20
Copy link
Contributor

weezy20 commented Aug 18, 2023

You can mark your pr ready for review. That should trigger it.

@Moliholy Moliholy marked this pull request as draft August 18, 2023 16:08
@Moliholy Moliholy marked this pull request as ready for review August 18, 2023 16:08
@weezy20
Copy link
Contributor

weezy20 commented Aug 21, 2023

try-runtime does not build. @Moliholy please check.

@Moliholy
Copy link
Contributor Author

@weezy20 true. I just fixed it.

@Moliholy Moliholy force-pushed the Moliholy/polkadot-v1.0.0 branch 3 times, most recently from 3949b03 to cb977bf Compare August 26, 2023 11:43
@Moliholy
Copy link
Contributor Author

Rebased to include the newest commits from wzy/polkadot-v0.9.43.

@stiiifff I did undo the cargo update command and tried to match the same versions of the dependencies as in the original substrate template. Take a look anyway just in case I missed something.

@Moliholy Moliholy force-pushed the Moliholy/polkadot-v1.0.0 branch 2 times, most recently from b804c2f to 647a67a Compare August 28, 2023 11:06
@Moliholy
Copy link
Contributor Author

@stiiifff ready for round two! 🚀

@Moliholy
Copy link
Contributor Author

@stiiifff I just realized the template pallet was renamed to pallet-parachain-template in the 0.9.43 migration. I differs from the original template, so I again renamed it to pallet-template in order to stick to it as much as possible. Should I change the name back to how it was?

@stiiifff stiiifff merged commit 0514d25 into main Aug 30, 2023
1 check passed
@stiiifff stiiifff deleted the Moliholy/polkadot-v1.0.0 branch August 30, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiiifff stiiifff stiiifff approved these changes

@weezy20 weezy20 Awaiting requested review from weezy20

Assignees

@Moliholy Moliholy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moliholy @weezy20 @stiiifff