Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] incorrect value for public-addr if service type is LoadBalancer #277

Closed
BulatSaif opened this issue Jul 11, 2023 · 0 comments · Fixed by #356
Closed

[node] incorrect value for public-addr if service type is LoadBalancer #277

BulatSaif opened this issue Jul 11, 2023 · 0 comments · Fixed by #356

Comments

@BulatSaif
Copy link
Contributor

Helm chart sets incorrect value for public-addr if service type is LoadBalancer

Here example of config for collator:

    perNodeServices:
      relayP2pService:
        enabled: true
        type: NodePort
      paraP2pService:
        enabled: true
        type: LoadBalancer
        port: 30333
        externalDns:
          enabled: true
          hostname: example.io.
          ttl: 60
        ws:
          enabled: true
          port: 30335
      setPublicAddressToExternalIp:
        enabled: true

and following variable will be set by pod:

{{- /* For non NodePort services, set the p2p port to value configured in `paraP2pService.port` */}}
PARA_CHAIN_P2P_PORT={{ $.Values.node.perNodeServices.paraP2pService.port | quote }}
EXTERNAL_IP=$(curl {{ .Values.node.perNodeServices.setPublicAddressToExternalIp.ipRetrievalServiceUrl }})

public-addr flag has following value:

--public-addr=/ip4/${EXTERNAL_IP}/tcp/${PARA_CHAIN_P2P_PORT}

This will be resulting to:

--public-addr=/ip4/node_ip:30333

this is incorrect, it should be either:

--public-addr=/ip4/node_ip:NodePort

or

--public-addr=/ip4/LoadBalancer_IP:30333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant