Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node] incorrect value for --public-addr if service type is LoadBalancer #356

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[node] incorrect value for --public-addr if service type is LoadBalancer #356

merged 1 commit into from
Aug 26, 2024

Conversation

BulatSaif
Copy link
Contributor

Fixes: #277

--public-addr=/ip4/${EXTERNAL_IP}/tcp/${PARA_CHAIN_P2P_PORT}

Before fix:

--public-addr=/ip4/external_k8s_node_ip/tcp/30333

after fix:

--public-addr=/ip4/external_k8s_node_ip/tcp/NodePort

@BulatSaif BulatSaif self-assigned this Aug 23, 2024
@BulatSaif BulatSaif merged commit 67f3163 into main Aug 26, 2024
3 checks passed
@BulatSaif BulatSaif deleted the bs/fix-p2p-port-2 branch August 26, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArshamTeymouri ArshamTeymouri ArshamTeymouri approved these changes

Assignees

@BulatSaif BulatSaif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[node] incorrect value for public-addr if service type is LoadBalancer
2 participants
@BulatSaif @ArshamTeymouri