Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cloudsql to faucet #286

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Added cloudsql to faucet #286

merged 2 commits into from
Aug 23, 2023

Conversation

mutantcornholio
Copy link
Contributor

@mutantcornholio mutantcornholio commented Aug 17, 2023

Couldn't find an existing chart here with cloudsql enabled, so I'm not really sure if this is enough on the helm-charts side.

A part of paritytech/polkadot-testnet-faucet#335

@mutantcornholio
Copy link
Contributor Author

hmmm, where are the secrets for the integration tests stored? Were they ever passing?

@BulatSaif
Copy link
Contributor

hmmm, where are the secrets for the integration tests stored? Were they ever passing?

Secrets are defined here:

SMF_BOT_MATRIX_ACCESS_TOKEN: "__GITHUB_SECRET_SMF_BOT_MATRIX_ACCESS_TOKEN"

I think the token was rotated, and we did not update it in github:
image

I am looking for a password for @parity_ci_bot:matrix.org to generate new token.

@BulatSaif
Copy link
Contributor

BulatSaif commented Aug 21, 2023

@mutantcornholio, thank you for your contribution. You did an excellent job with the PostgreSQL deployment. However, it's not entirely clear to me how the application will obtain information to connect to database.

I've pushed a commit and added an environment variable to the application container containing the PostgreSQL credentials. You can verify that the database is functioning correctly from the application container using the following command:

apk add postgresql-client
PGPASSWORD=$POSTGRESQL_PASSWORD psql --username=$POSTGRESQL_USERNAME --host=$POSTGRESQL_HOST --port=$POSTGRESQL_PORT --dbname=$POSTGRESQL_DATABASE

I've used the POSTGRESQL_ prefix for the environment variable. If your application expects different environment variables, please feel free to update the names accordingly.

@mutantcornholio
Copy link
Contributor Author

I've pushed a commit and added an environment variable to the application container containing the PostgreSQL credentials. You can verify that the database is functioning correctly from the application container using the following command:

tbh, I was thinking on passing it on the usage side, in cloud-infra. But now when I think of it, that'd be definitely worse :)

I've used the POSTGRESQL_ prefix for the environment variable. If your application expects different environment variables, please feel free to update the names accordingly.

Yeah, it does expect those, alinged with bitnami images.

@mutantcornholio mutantcornholio merged commit 772f273 into main Aug 23, 2023
1 of 2 checks passed
@mutantcornholio mutantcornholio deleted the yuri/faucet-cloudsql branch August 23, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants