Add genereric command/params for bridge-relay

[PierreBesson]

Breaking change, revamp how the bridge relayer configuration is set.

[BulatSaif]

Kubernetes has separate field for command, if we set command in args it will confuse users.

spec:
  containers:
  - name: command-demo-container
    command: ["printenv"]
    args: ["HOSTNAME", "KUBERNETES_PORT"]

currently the default value for command is ENTRYPOINT ["/home/user/bridge-entrypoint.sh"]

[PierreBesson]

I'm not sure how to call it. But we have multiple commands within the relayer binary. Maybe we can call it subcommand ?

[BulatSaif]

Maybe let's use a list instead of strings/maps.

I see at least 2 use cases not covered by this PR:

1. What will we do if we have 2 or 3 subcommands?
2. How do we pass the list of valid bash parameters:

--lane 00000001 \
--lane 00000002 \
--dry-run

I assume it would be like this:

.Values.params:
  lane: '00000001'
  lane: '00000002'
  dry-run: ''

but this would result in invalid YAML (key lane present twice) and render output:

--lane=00000002 \
--dry-run=

I propose having a single .Values.args: [ ].
For example, for code like this:

subcommand1  \
subcommand2 \
subcommand3 \
--lane 00000001 \
--lane 00000002 \
--dry-run

we would have values:

.Values.args:
 - subcommand1
 - subcommand2
 - subcommand3
 - "--lane 00000001"
 - "--lane 00000002"
 - "--dry-run"

[PierreBesson]

OK let's go with your solution of only one "params" variable.

[PierreBesson]

I implemented the single var solution. Also removed the previous way to set flags so this is a breaking change.

[BulatSaif]

we already have Values.extraArgs to put any genereric command.

[PierreBesson]

we already have Values.extraArgs to put any genereric command.

Yes but with these variables it makes it more clear what needs to be set...