Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional improvements to integrate pubsub with Parity #110

Merged
merged 4 commits into from
Apr 13, 2017

Conversation

tomusdrw
Copy link
Contributor

Closes #109

@tomusdrw tomusdrw requested a review from rphmeier April 12, 2017 14:01

fn start_send(&mut self, item: Self::SinkItem) -> futures::StartSend<Self::SinkItem, Self::SinkError> {
if self.poll()?.is_not_ready() {
return Ok(futures::AsyncSink::NotReady(item));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to schedule a Task wakeup?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it doesn't, but putting the rationale why in a comment above (since futures have a lot of hidden complexity) would help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@debris
Copy link
Contributor

debris commented Apr 13, 2017

I am not familiar with how future::Sink works, so I can only assume that the logic is 100% correct. The pr itself looks good

@tomusdrw
Copy link
Contributor Author

Nightly failure seems unrelated to the changes. See rust-lang/rustup#1062 for more details.

@tomusdrw tomusdrw merged commit a95e135 into master Apr 13, 2017
@tomusdrw tomusdrw deleted the more-improvements branch April 13, 2017 13:41
tomusdrw added a commit that referenced this pull request Apr 13, 2017
* Cloneable types

* Adding Origin to RequestContext

* Sink implementations.

* Add comment regarding Task wakeup.
tomusdrw added a commit that referenced this pull request Apr 13, 2017
* Improving the external API. (#108)

* Improving the external API.

* Fix output format for subscriptions.

* Additional improvements to integrate pubsub with Parity (#110)

* Cloneable types

* Adding Origin to RequestContext

* Sink implementations.

* Add comment regarding Task wakeup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants