-
Notifications
You must be signed in to change notification settings - Fork 170
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[server] proper handling of batch errors and mixed calls (#917)
* fix: proper error on invalid batches * proper handling of batch request errors * ordered futures * remove needless boxing Co-authored-by: Alexander Polakov <a.polakov@zubr.io>
- Loading branch information
Showing
7 changed files
with
198 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
e649f38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.sync/http_batch_requests/fast_call/5
189864
ns/iter (± 62728
)93775
ns/iter (± 1986
)2.02
sync/http_batch_requests/fast_call/10
209835
ns/iter (± 27088
)104752
ns/iter (± 1942
)2.00
sync/ws_round_trip/fast_call
125729
ns/iter (± 19276
)62272
ns/iter (± 3422
)2.02
sync/ws_batch_requests/fast_call/2
143240
ns/iter (± 33698
)69257
ns/iter (± 975
)2.07
sync/ws_batch_requests/fast_call/5
159469
ns/iter (± 23985
)79589
ns/iter (± 1577
)2.00
async/ws_round_trip/fast_call
131514
ns/iter (± 27889
)62359
ns/iter (± 1344
)2.11
async/ws_batch_requests/fast_call/2
142929
ns/iter (± 17205
)69975
ns/iter (± 1152
)2.04
async/ws_batch_requests/fast_call/5
160161
ns/iter (± 22977
)79819
ns/iter (± 1653
)2.01
subscriptions/subscribe
185176
ns/iter (± 28250
)85880
ns/iter (± 1894
)2.16
This comment was automatically generated by workflow using github-action-benchmark.
CC: @niklasad1
e649f38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.sync/ws_concurrent_conn_calls/fast_call/8
1692296
ns/iter (± 26815
)757773
ns/iter (± 55593
)2.23
sync/ws_concurrent_conn_calls/fast_call/32
5532557
ns/iter (± 106633
)2682021
ns/iter (± 70905
)2.06
sync/ws_concurrent_conn_calls/fast_call/64
10508181
ns/iter (± 225813
)5167166
ns/iter (± 93270
)2.03
sync/ws_concurrent_conn_subs/1024
158770692
ns/iter (± 818524
)78120255
ns/iter (± 858715
)2.03
async/ws_concurrent_conn_calls/fast_call/32
5498146
ns/iter (± 79331
)2673624
ns/iter (± 75070
)2.06
async/ws_concurrent_conn_calls/fast_call/64
10440471
ns/iter (± 217372
)5141961
ns/iter (± 114534
)2.03
async/ws_concurrent_conn_subs/1024
158857767
ns/iter (± 904006
)78027613
ns/iter (± 975727
)2.04
This comment was automatically generated by workflow using github-action-benchmark.
CC: @niklasad1
e649f38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.sync/ws_concurrent_conn_calls/fast_call/8
1671923
ns/iter (± 32155
)757773
ns/iter (± 55593
)2.21
sync/ws_concurrent_conn_calls/fast_call/32
5501062
ns/iter (± 120067
)2682021
ns/iter (± 70905
)2.05
sync/ws_concurrent_conn_calls/fast_call/64
10482054
ns/iter (± 354570
)5167166
ns/iter (± 93270
)2.03
sync/ws_concurrent_conn_subs/1024
158882595
ns/iter (± 1037824
)78120255
ns/iter (± 858715
)2.03
async/ws_concurrent_conn_calls/fast_call/32
5499119
ns/iter (± 69507
)2673624
ns/iter (± 75070
)2.06
async/ws_concurrent_conn_calls/fast_call/64
10465082
ns/iter (± 263403
)5141961
ns/iter (± 114534
)2.04
async/ws_concurrent_conn_subs/1024
158707960
ns/iter (± 920591
)78027613
ns/iter (± 975727
)2.03
This comment was automatically generated by workflow using github-action-benchmark.
CC: @niklasad1