Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split jsonrpsee::core::Error to ClientError and ServerError error types #1088

Closed
niklasad1 opened this issue Apr 20, 2023 · 0 comments · Fixed by #1122
Closed

split jsonrpsee::core::Error to ClientError and ServerError error types #1088

niklasad1 opened this issue Apr 20, 2023 · 0 comments · Fixed by #1122
Milestone
[public] v1.0 and...

Comments

@niklasad1
Copy link
Member

niklasad1 commented Apr 20, 2023 •
edited
Loading

Currently jsonrpsee has a big error type which has many variants that are not applicable for the server and vice verse for the client.

Thus, we should try to split it up to help for make it easier to understand and to help dealing with #1067
@niklasad1 niklasad1 added this to the v1.0 milestone Apr 25, 2023
@niklasad1 niklasad1 changed the title split error type to Client and Server error types split jsonrpsee::core::Error to ClientError and ServerError error types Apr 25, 2023
@niklasad1 niklasad1 mentioned this issue May 15, 2023
Merged
oleonardolima added a commit to oleonardolima/fedimint that referenced this issue Dec 13, 2023
@oleonardolima
fix: use specific jsonrpsee_core::client::Error
5ac6a80 
- the jsonrpsee 0.21.0 release splitted the previous client/server
  `Error` into specific variants for each one, check:
  paritytech/jsonrpsee#1088
@oleonardolima oleonardolima mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
[public] v1.0 and move to maintenance
Development

Successfully merging a pull request may close this issue.

refactor: split client and server errors paritytech/jsonrpsee
1 participant
@niklasad1