[ws client]: ChannelClosed message should embed request_id
#169
Comments
niklasad1
added a commit
that referenced
this issue
Dec 1, 2020
niklasad1
added a commit
that referenced
this issue
Dec 1, 2020
niklasad1
added a commit
that referenced
this issue
Dec 2, 2020
* fix(ws client): embed request id SubscriptClosed Fixes #169 * Update src/client/ws/client.rs * Update src/client/ws/client.rs Co-authored-by: David <dvdplm@gmail.com> * Update src/client/ws/client.rs Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: David <dvdplm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a subscription is closed, all the subscriptions are iterated over and returns once a closed subscription is found, which is inefficient and could close the wrong subscription if "several are closed at the same time", see https://github.com/paritytech/jsonrpsee/blob/v2/src/client/ws/client.rs#L303-#L309
Thus, it would be better to just have
ChannelClosed(RequestId)than it could be performed in constant time and is correct.The text was updated successfully, but these errors were encountered: