server: replace FutureDriver with tokio::spawn
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
FutureDriver with tokio::spawn
niklasad1
commented
Apr 14, 2023
| @@ -419,21 +356,19 @@ pub(crate) async fn background_task<L: Logger>( | |||
| async fn send_task( | |||
| rx: mpsc::Receiver<String>, | |||
| mut ws_sender: Sender, | |||
| stop_handle: StopHandle, | |||
There was a problem hiding this comment.
Basically, the stop handle was passed directly to send task and that stopped when it got the stop signal but it could be the case the pending calls were still in the queue and those were just canceled
so, I changed that we wait until those pending calls are finished and then stop
jsdw
reviewed
Apr 14, 2023
jsdw
approved these changes
Apr 14, 2023
niklasad1
commented
Apr 15, 2023
| // executed and the connection has been closed. | ||
| tokio::select! { | ||
| // All pending calls executed. | ||
| _ = pending_calls.for_each(|_| async {}) => { |
There was a problem hiding this comment.
So, we could also timeout out this after 10 minutes or something if someone has a infinite loop or something that never returns in some scenario it may "leak" and never terminate...
niklasad1
commented
Apr 17, 2023
|
|
||
| module | ||
| .register_async_method("infinite_call", |_, _| async move { | ||
| futures_util::future::pending::<()>().await; |
There was a problem hiding this comment.
This a really bad and shouldn't be used in "real code" but just a way to ensure that the futures won't ever complete.
tadeohepperle
approved these changes
Apr 17, 2023
lexnv
approved these changes
Apr 17, 2023
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1063