Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get connection id from PendingSubscriptionSink #1163

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: get connection id from PendingSubscriptionSink #1163

merged 1 commit into from
Aug 2, 2023

Conversation

bmuddha
Copy link
Contributor

@bmuddha bmuddha commented Aug 2, 2023

adds public associated method to PendingSubscriptionSink, which allows for retrieval of connection identifier, which was used to perform subscription request

motivation: sometimes it's useful to have a link between websocket subscription and websocket connection, e.g. for preventing duplicate subscriptions on the same connection. Currently there's no API exposing underlying connection identifier, so this PR adds a public method just for this purpose.

adds public associated method to PendingSubscriptionSink,
which allows for retrieval of connection identifier, which
was used to perform subscription request
@bmuddha bmuddha requested a review from a team as a code owner August 2, 2023 11:07
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks non-contentious to me :)

@niklasad1
Copy link
Member

yeah, we should probably the same to the SubscriptionSink as well for a uniform API :)

@niklasad1 niklasad1 merged commit e807d9c into paritytech:master Aug 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants