refactor(client): support default port number #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Aug 9, 2023
niklasad1
commented
Aug 9, 2023
| async fn ws_with_non_ascii_url_doesnt_hang_or_panic() { | ||
| init_logger(); | ||
|
|
||
| let err = WsClientBuilder::default().build("wss://♥♥♥♥♥♥∀∂").await; |
There was a problem hiding this comment.
The URL crate regards non-ascii chars as a valid URL
|
Woooo, looks good to me (It's also well tested which is reassuring!) |
lexnv
approved these changes
Aug 9, 2023
tadeohepperle
approved these changes
Aug 9, 2023
oleonardolima
added a commit
to oleonardolima/fedimint
that referenced
this pull request
Oct 25, 2023
- the previous issue with jsonrpsee correctly parsing the &str from SafeUrl seems to be solved on the latest 0.20.0 release, as per the discussion and CHANGELOG: https://github.com/paritytech/jsonrpsee/blob/v0.20.x/CHANGELOG.md#changed-2 and PR: paritytech/jsonrpsee#1172
oleonardolima
added a commit
to oleonardolima/fedimint
that referenced
this pull request
Oct 25, 2023
- the previous issue with jsonrpsee correctly parsing the &str from SafeUrl seems to be solved on the latest 0.20.0 release, as per the discussion and CHANGELOG: https://github.com/paritytech/jsonrpsee/blob/v0.20.x/CHANGELOG.md#changed-2 and PR: paritytech/jsonrpsee#1172
oleonardolima
added a commit
to oleonardolima/fedimint
that referenced
this pull request
Nov 8, 2023
- the previous issue with jsonrpsee correctly parsing the &str from SafeUrl seems to be solved on the latest 0.20.0 release, as per the discussion and CHANGELOG: https://github.com/paritytech/jsonrpsee/blob/v0.20.x/CHANGELOG.md#changed-2 and PR: paritytech/jsonrpsee#1172
oleonardolima
added a commit
to oleonardolima/fedimint
that referenced
this pull request
Nov 10, 2023
- the previous issue with jsonrpsee correctly parsing the &str from SafeUrl seems to be solved on the latest 0.20.0 release, as per the discussion and CHANGELOG: https://github.com/paritytech/jsonrpsee/blob/v0.20.x/CHANGELOG.md#changed-2 and PR: paritytech/jsonrpsee#1172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1048 and #1169
I switched to the
urlcrate which supports default port numbers and once theUrl::parsefails withRelativeUrErrorlon a redirection then it's treated as well-formed. If it fails then connection will be dropped anyway.