graceful shutdown: distinguish between stopped and conn closed #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Oct 19, 2023
jsdw
approved these changes
Oct 19, 2023
niklasad1
added a commit
that referenced
this pull request
Oct 24, 2023
* graceful shutdown: distinguish between stopped and conn closed * grumbles: ws_stream fuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1218
Basically, I missed that we must ensure that the stream is not polled after
Poll::Ready(None)which can happenif the stream is closed but since
Receive::Shutdown was mapped to Shutdown::Stoppedwhere the connection could already have been closed and thus the stream had already returnPoll::Ready(None)