Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http client builder): Add max_concurrent_requests setter #1470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sydhds
Copy link

@sydhds sydhds commented Oct 8, 2024

No description provided.

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "feature" has been removed and has no effect anymore.

We/I forgot to remove the max_concurrent_request field on the builder because it was not ergonomic to use in async to code to wait until one would get MaxSlotsExceeded ...

For now you enforce the "limit" yourself for example with a semaphore/channel or something like that. Ideally with a channel bounded channel to provide backpressure which is much more ergonomic to deal with in async code.

However, I reckon that the API is not really uniform anymore compared to the "ws-client/async-client" APIs which provides max_concurrent_requests. So we could add "it back" to http-client but with backpressure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants