Pass OwnedRpcParams to async methods #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
commented
Jul 9, 2021
dvdplm
commented
Jul 9, 2021
|
Might have to mess a bit more with lifetimes, or do an extra quasi iterator for parsing using let a: &str = params.next();
let b: &str = params.next(); // a is using a lifetime that's bound to a mutable borrow, hence borrowck forbids this thinking it's aliasing |
dvdplm
commented
Jul 9, 2021
maciejhirsz
reviewed
Jul 10, 2021
Comment on lines
+403
to
+408
| let params = RpcParams::new(Some(r#"["foo", "bar"]"#)); | ||
| let mut seq = params.sequence(); | ||
|
|
||
| assert_eq!(seq.next::<&str>().unwrap(), "foo"); | ||
| assert_eq!(seq.next::<&str>().unwrap(), "bar"); | ||
| assert!(seq.next::<&str>().is_err()); |
There was a problem hiding this comment.
This is the important test and the reason for adding a separate struct for handling sequence parsing: seq borrows the json from params, which allows it to produce slices with that lifetime, while &mut self borrows are transient.
Test that parse() works after calling sequence()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
OwnedRpcParamsto async methods to allow deserializing to happen asynchronously as well.Closes #408