[proc macros] force proc macro api to return Result
#435
Conversation
…ro-api-to-return-result
The rationale is to make it possible for users to either use anyhow::Error or use the helper methods.
utils/src/server/rpc_module.rs
Outdated
| pub fn register_method<R, F, E>(&mut self, method_name: &'static str, callback: F) -> Result<(), Error> | ||
| where | ||
| Context: Send + Sync + 'static, | ||
| R: Serialize, | ||
| F: Fn(RpcParams, &Context) -> Result<R, CallError> + Send + Sync + 'static, | ||
| F: Fn(RpcParams, &Context) -> Result<R, E> + Send + Sync + 'static, | ||
| E: Into<Error>, |
There was a problem hiding this comment.
Now that we have three generics is perhaps a good time to use more explicit naming. I also think the more logical order would be F, R, E perhaps?
How about:
F –> Method,
R –> RetVal,
E –> MethodError
There was a problem hiding this comment.
if we put F, R, E, you will probably be annoyed
Because F the closure that you provide is always known by the compiler so in practice you would have to do this:
module.register_method::<_, (), Error>("hello_world", |_: RpcParams, _| Ok(())).unwrap();
isn't <R,E,F> better then?
There was a problem hiding this comment.
I decided the revert the Into<Error> as this doesn't really work out-of-the-box when having the client in the API.
Basically, Client::request -> Error then we would require the custom error type to implement both From<CustomError> and From<jsonrpsee::Error, I prefer to tackle it another PR to actually make it work properly.
This reverts commit 33b4fa2.
…ro-api-to-return-result
…ro-api-to-return-result
Similar to #435 that adds the same restrictions to subscriptions too. To avoid having faulty trait bounds on when the subcription actually returns Result.
Similar to #435 that adds the same restrictions to subscriptions too. To avoid having faulty trait bounds on when the subcription actually returns Result.
A little controversial solution to #403 (comment), to require each RPC method in the
proc macro APIto require the method to returnJsonRpcResult<T, jsonrpsee_types::Error>