Reject overflowing connection with status code 429 #456
+88
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Sep 9, 2021
niklasad1
reviewed
Sep 9, 2021
| server.send_response(&reject).await?; | ||
|
|
||
| return Err(error); | ||
| Ok(()) |
There was a problem hiding this comment.
what does Ok(()) vs Err(error) imply here?
I suppose we don't have any error for it in Incoming and return Ok(()) is probably fine because it's already logged once the connection limit is exceeded when Handshake::Reject is detected.
There was a problem hiding this comment.
Yup, returning 429 rejection isn't an error here, it's expected behavior (but we can still get an io error when sending the response for whatever reason).
niklasad1
approved these changes
Sep 9, 2021
dvdplm
reviewed
Sep 10, 2021
dvdplm
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #398.
Needs an extra PR in soketto to add the
Retry-Afterheader, although I think this might be a case of perfect is the enemy of good here.