Rename and reorg types

[dvdplm]

⚠️ Breaking change ⚠️

Closes #457.

The changes here mostly removes the JsonRpc prefix from the types that come from the spec. I have kept a prefix for some types with a very common stdlib version such as Result and Error. I also changed the serializable versions to consistently use the *Ser postfix (not loving this convention but have no better suggestion).

I'm tempted to make the jsonrpsee-types paths more shallow, i.e. re-export all the modules under v2, so that instead of doing jsonrpsee-types::v2::error::RpcError we'd have jsonrpsee-types::v2::RpcError; instead of jsonrpsee-types::v2::response::Response we'd have jsonrpsee-types::v2::Response etc. Thoughts?

[maciejhirsz]

How about CallParams instead of ParamsSer? Or, if we want to be slightly confusing but pedantically correct: Arguments.

[dvdplm]

How about CallParams instead of ParamsSer? Or, if we want to be slightly confusing but pedantically correct: Arguments.

GH threw away my reply to this, grr.

I like Arguments quite a lot, but I don't think it's wise to move away from "params" because the spec uses "parameter" throughout and I don't think it's good to ask users/readers to map from one to the other.

The downside of going with CallParams is that it doesn't help with the other *Ser types: RequestSer and NotificationSer. Using a post-fix has the advantage of clearly communicating what is peculiar about all three of them.

:/

[niklasad1]

I'm tempted to make the jsonrpsee-types paths more shallow, i.e. re-export all the modules under v2, so that instead of doing jsonrpsee-types::v2::error::RpcError we'd have jsonrpsee-types::v2::RpcError; instead of jsonrpsee-types::v2::response::Response we'd have jsonrpsee-types::v2::Response etc. Thoughts?

Sounds good to me

[niklasad1]

How about CallParams instead of ParamsSer? Or, if we want to be slightly confusing but pedantically correct: Arguments.

We have used Params because the spec states that. I think CallParams is slightly confusing because when the server receives the params it's still a call?! At least ParamsSer is super obvious too me even if it's a bit "verbose"

Arguments could work though....

[niklasad1]

LGTM, some minor comments to address

In an followup PR, we could flatten the v2 mod and remove the child modules request, response, params.

[dvdplm]

In an followup PR, we could flatten the v2 mod and remove the child modules request, response, params.

#468

[maciejhirsz]

Aside form my initial bikeshed it looks good to me :)