[http server]: export acl types + remove cors_max_age #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
niklasad1
changed the title
|
I think this is better than what I had in #465 but the question about where we send back this header should be. I don't think this fixes that, or…? |
No, it just provides the "functionality" to fetch the cors_max_age. I can fix it in this PR or a follow-up doesn't really matter to me |
|
I'm tempted to go with @maciejhirsz's suggestion and remove the field entirely (until we know we need it). |
Yes, I like that idea :+1 |
niklasad1
changed the title
dvdplm
approved these changes
Sep 15, 2021
maciejhirsz
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.