Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace array_impl macro with const generics #470

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

niklasad1
Copy link
Member

@jsdw
Copy link
Collaborator

jsdw commented Sep 15, 2021

LGTM! Since there doesn't appear to be a zero-length array of zero-tuple impl, It's a little harder to pass in 0 params. Is it worth impling the trait on an empty tuple as well just to cover that?

(also, the $len part of the tuple impl isn't used so I wonder if it's worth keeping around?)

@dvdplm dvdplm merged commit e0635fd into master Sep 16, 2021
@dvdplm dvdplm deleted the na-intorpc-params-const-generics branch September 16, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants