Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benches: add option to run benchmarks against jsonrpc crate servers #527

Merged
merged 16 commits into from
Oct 17, 2021
Merged

benches: add option to run benchmarks against jsonrpc crate servers #527

merged 16 commits into from
Oct 17, 2021

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 changed the title benches: add option to run benchmarks again jsonrpc crate benches: add option to run benchmarks again jsonrpc crate servers Oct 15, 2021
dvdplm
dvdplm approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dq: are benchmark runs stored permanently? They're not right?

@niklasad1
Copy link
Member Author

niklasad1 commented Oct 15, 2021 •
edited
Loading

dq: are benchmark runs stored permanently? They're not right?

benchmark runs are stored permanently in gh-pages branch in dev/bench but I did a dummy one just to run jsonrpsee vs jsonrpc in gh-pages-v0.3 in this PR.

however, jsonrpc vs jsonrpsee doesn't belong there so the plan is to have gh-pages/dev/jsonrpc where we compare them otherwise I don't know how to plot them.

@niklasad1 niklasad1 changed the title benches: add option to run benchmarks again jsonrpc crate servers benches: add option to run benchmarks against jsonrpc crate servers Oct 15, 2021
@dvdplm dvdplm merged commit 0b43555 into master Oct 17, 2021
@dvdplm dvdplm deleted the na-benches-to-jsonrpc-crate branch October 17, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@maciejhirsz maciejhirsz Awaiting requested review from maciejhirsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasad1 @dvdplm