clients: request ID as RAII guard #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Oct 28, 2021
jsdw
reviewed
Nov 1, 2021
| .map(|_| ()) | ||
| .map_err(|_| Error::MaxSlotsExceeded) | ||
| fn get_slot(&self) -> Result<Arc<()>, Error> { | ||
| // Strong count is 1 at start, so that's why we use `>` and not `>=`. |
jsdw
reviewed
Nov 1, 2021
jsdw
reviewed
Nov 1, 2021
types/src/client.rs
Outdated
| _rc: Arc<()>, | ||
| } | ||
|
|
||
| impl<T> RequestId<T> { |
There was a problem hiding this comment.
I guess this could be a Deref impl too, but given how it's used I wouldn't mind either way!
`RequestIdGuard` -> `RequestIdManager` `RequestId` -> `RequestIdGuard`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale behind this change is to reduce the technical debt, not to require us to remember to reclaim a request ID when a request was completed successful or not.