clients: feature gate tls
#545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Nov 1, 2021
niklasad1
force-pushed
the
na-clients-opt-of-from-tls
branch
from
3b39d60
to
2d9020a
Compare
niklasad1
commented
Dec 3, 2021
| #[derive(Debug, Copy, Clone)] | ||
| pub enum EitherStream<S, T> { | ||
| #[derive(Debug)] | ||
| pub enum EitherStream { |
There was a problem hiding this comment.
I did this but I realized I can just used placeholder type such as () to keep the generics here not sure that we need the generics anyway.
Unless we plan to support any transport using tokio rustls :)
niklasad1
commented
Dec 3, 2021
| for _ in 0..self.max_redirections { | ||
| tracing::debug!("Connecting to target: {:?}", target); | ||
|
|
||
| // The sockaddrs might get reused if the server replies with a relative URI. | ||
| let sockaddrs = std::mem::take(&mut target.sockaddrs); | ||
| for sockaddr in &sockaddrs { | ||
| let tcp_stream = match connect(*sockaddr, self.timeout, &target.host, &tls_connector).await { | ||
| #[cfg(feature = "tls")] |
There was a problem hiding this comment.
I had to do this to avoid feature gate the entire method.
niklasad1
changed the title
tls
maciejhirsz
reviewed
Dec 6, 2021
|
|
||
| [features] | ||
| default = ["tls"] | ||
| tls = ["hyper-rustls/webpki-tokio"] |
maciejhirsz
approved these changes
Dec 6, 2021
yeah, we have this which should compile each crate with |
niklasad1
commented
Dec 6, 2021
| jsonrpsee-types = { path = "../types", version = "0.6.0" } | ||
| jsonrpsee-utils = { path = "../utils", version = "0.6.0", features = ["client", "http-helpers"] } | ||
| serde = { version = "1.0", default-features = false, features = ["derive"] } | ||
| serde_json = "1.0" | ||
| thiserror = "1.0" | ||
| tokio = { version = "1.8", features = ["time"] } | ||
| tracing = "0.1" | ||
| url = "2.2" |
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #241