proc-macros: Support deprecated methods for rpc client #570
Conversation
Calling a deprecated method of the RPC client should warn the user at compile-time. Extract the `#[deprecated]` macro as is while parsing the RpcMethod, and pass through the macro to the RPC client rendering.
To ensure that the test will fail during compilation, warnings are denied. Check that the deprecate macro will generate warnings just for the methods that are utilized.
There was a problem hiding this comment.
Code looks super clean despite proc macros being notoriously hard to navigate, and tests are spot on so this is definitely a pass from me! :)
I'm looking over the issue now and I'm a bit confused about what the intended deprecation message should be there (as in, should have a log on the server, or send something in the JSON response?), but this is definitely a valid interpretation! If there is anything we want to change we can do that outside of this PR.
Cheers, and have a great Sunday :)
|
@lexnv Good stuff here, tyvm. Can you please edit the description of the PR adding your polkadot address on a separate line like so |
Calling a deprecated method of the RPC client should warn
the user at compile-time.
Extract the
#[deprecated]macro as is while parsing theRpcMethod, and pass through the macro to the RPC client
rendering.
Testing
To ensure that the test will fail during compilation,
warnings are denied.
Check that the deprecate macro will generate warnings
just for the methods that are utilized.