Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http client): set reuseaddr and nodelay. #687

Merged
merged 8 commits into from
Mar 29, 2022
Merged

fix(http client): set reuseaddr and nodelay. #687

merged 8 commits into from
Mar 29, 2022

Conversation

niklasad1
Copy link
Member

No description provided.

@dvdplm
Copy link
Contributor

dvdplm commented Feb 22, 2022

@niklasad1 Do we still want to do this, even though it doesn't fix the benches on macos? I didn't look into the windows CI failure, maybe we need some cfg-fu to make it work?

@niklasad1
Copy link
Member Author

@niklasad1 Do we still want to do this, even though it doesn't fix the benches on macos? I didn't look into the windows CI failure, maybe we need some cfg-fu to make it work?

Good catch I forgot about this one.
Yes, I think we should include this anyway.

@niklasad1 niklasad1 marked this pull request as ready for review February 23, 2022 10:39
@niklasad1 niklasad1 requested a review from a team as a code owner February 23, 2022 10:39
jsdw
jsdw approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me; I'm not really sure of the ramifications of reuseport and reuseaddress being set though!

@niklasad1
Copy link
Member Author

Looks sane to me; I'm not really sure of the ramifications of reuseport and reuseaddress being set though!

Yeah, I'm not sure about reuseport at least I'll remove it.

@niklasad1 niklasad1 merged commit 3f13274 into master Mar 29, 2022
@niklasad1 niklasad1 deleted the http-client-reuse-addr branch March 29, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@jsdw jsdw jsdw approved these changes

@TarikGul TarikGul TarikGul approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niklasad1 @dvdplm @jsdw @TarikGul @lexnv