Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a way to limit the number of subscriptions per connection #739

Merged
merged 13 commits into from
May 3, 2022
Merged

feat: add a way to limit the number of subscriptions per connection #739

merged 13 commits into from
May 3, 2022

Commits on Apr 26, 2022

  1. feat: limit the number of subscriptions 

    Closing #729
    @niklasad1
    niklasad1 committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a38045c View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. fix nit

    @niklasad1
    niklasad1 committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    f61ac0e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Update core/src/server/helpers.rs

    @niklasad1
    niklasad1 authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    761eea4 View commit details
    Browse the repository at this point in the history

  2. add integration tests + some fixes so it works

    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    d78029e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into na-fix-729

    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    9ca7bd4 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. cargo fmt

    @niklasad1
    niklasad1 committed May 1, 2022
    Configuration menu
    Copy the full SHA
    fdbffe9 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. fix doc links

    @niklasad1
    niklasad1 committed May 2, 2022
    Configuration menu
    Copy the full SHA
    96189b0 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Unsubscribe calls should avoid subscription limits 

    Point to Tokio 1.16 (we use a method from it), and a little special treatment for unsubscribe methods
    @jsdw
    jsdw authored May 3, 2022
    Configuration menu
    Copy the full SHA
    7ac1fd6 View commit details
    Browse the repository at this point in the history

  2. No resource limiting for Unsubscribe calls

    @jsdw
    jsdw committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5aad4f4 View commit details
    Browse the repository at this point in the history

  3. Test that we can still unsubscribe after hitting a limit

    @jsdw
    jsdw committed May 3, 2022
    Configuration menu
    Copy the full SHA
    79d05bf View commit details
    Browse the repository at this point in the history

  4. Fix a comment typo 

    Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
    @jsdw @lexnv
    jsdw and lexnv authored May 3, 2022
    Configuration menu
    Copy the full SHA
    a704929 View commit details
    Browse the repository at this point in the history

  5. Update core/src/server/rpc_module.rs

    @niklasad1
    niklasad1 authored May 3, 2022
    Configuration menu
    Copy the full SHA
    21009a9 View commit details
    Browse the repository at this point in the history

  6. Update core/src/server/rpc_module.rs

    @niklasad1
    niklasad1 authored May 3, 2022
    Configuration menu
    Copy the full SHA
    dfedaa7 View commit details
    Browse the repository at this point in the history