Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ping-pong for WebSocket clients #772

Merged
merged 40 commits into from
Jun 1, 2022
Merged

Implement ping-pong for WebSocket clients #772

merged 40 commits into from
Jun 1, 2022

Commits on May 17, 2022

  1. ws: Implement ping for TransportSenderT trait 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 17, 2022
    Configuration menu
    Copy the full SHA
    1162d3e View commit details
    Browse the repository at this point in the history

  2. ws/client: Receive pong frames 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 17, 2022
    Configuration menu
    Copy the full SHA
    2a76701 View commit details
    Browse the repository at this point in the history

  3. core/client: Use select! macro for the background task 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 17, 2022
    Configuration menu
    Copy the full SHA
    80af45a View commit details
    Browse the repository at this point in the history

  4. client: Propagate ping interval to background task 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 17, 2022
    Configuration menu
    Copy the full SHA
    63ba7e7 View commit details
    Browse the repository at this point in the history

  5. async_client: Submit ping requests 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 17, 2022
    Configuration menu
    Copy the full SHA
    0d3534c View commit details
    Browse the repository at this point in the history

  6. async_client: Handle pong replies 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 17, 2022
    Configuration menu
    Copy the full SHA
    23ad9b9 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. client: Handle frontend messages to dedicated fn 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 19, 2022
    Configuration menu
    Copy the full SHA
    48b5db9 View commit details
    Browse the repository at this point in the history

  2. client: Handle backend messages in dedicated fn 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c86b08e View commit details
    Browse the repository at this point in the history

  3. client: Add terminated fuse for opt-out pings 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 19, 2022
    Configuration menu
    Copy the full SHA
    ae5bf75 View commit details
    Browse the repository at this point in the history

  4. Set opt-out behavior for client pings 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0ee78c5 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into 738_ping_pong

    @lexnv
    lexnv committed May 19, 2022
    Configuration menu
    Copy the full SHA
    8e82ad1 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. client: Move imports 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    e7c6edb View commit details
    Browse the repository at this point in the history

  2. client: Handle handle_frontend_messages errors 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    9c5f235 View commit details
    Browse the repository at this point in the history

  3. client: Add custom error related to byteslice conversions 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    8e3ff40 View commit details
    Browse the repository at this point in the history

  4. client: Modify send_ping to send empty slices 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    7d39b6f View commit details
    Browse the repository at this point in the history

  5. Fix cargo hack check and use select_biased 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    64a7b99 View commit details
    Browse the repository at this point in the history

  6. Handle sending pings with lowest priority 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    1559554 View commit details
    Browse the repository at this point in the history

  7. core: Add proper number of params to background_task 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    5ba4d0e View commit details
    Browse the repository at this point in the history

  8. Fix wasm client 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    aed7d26 View commit details
    Browse the repository at this point in the history

  9. Handle raw bytes and string received messages 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    48d6eec View commit details
    Browse the repository at this point in the history

  10. Fix Cargo.toml feature 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    cda4c09 View commit details
    Browse the repository at this point in the history

  11. Panic when empty slice does not fit into ByteSlice125 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 20, 2022
    Configuration menu
    Copy the full SHA
    13ee47a View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. wasm: Add operation not supported for pings 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 24, 2022
    Configuration menu
    Copy the full SHA
    6b40519 View commit details
    Browse the repository at this point in the history

  2. Rename ReceivedMessage from Data to Text 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 24, 2022
    Configuration menu
    Copy the full SHA
    537627f View commit details
    Browse the repository at this point in the history

  3. Rename test variable 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 24, 2022
    Configuration menu
    Copy the full SHA
    2a2787f View commit details
    Browse the repository at this point in the history

  4. Add documentation 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 24, 2022
    Configuration menu
    Copy the full SHA
    a9bed1e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into 738_ping_pong

    @lexnv
    lexnv committed May 24, 2022
    Configuration menu
    Copy the full SHA
    4861c14 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. client: Use future::select for cancel safety 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 26, 2022
    Configuration menu
    Copy the full SHA
    fb7ea4d View commit details
    Browse the repository at this point in the history

  2. client: Remove pong handling logic 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 26, 2022
    Configuration menu
    Copy the full SHA
    736da11 View commit details
    Browse the repository at this point in the history

  3. client: Update ping documentation 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 26, 2022
    Configuration menu
    Copy the full SHA
    b262442 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Update core/src/client/async_client/mod.rs 

    Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
    @lexnv @TarikGul
    lexnv and TarikGul authored May 27, 2022
    Configuration menu
    Copy the full SHA
    2d6b04c View commit details
    Browse the repository at this point in the history

  2. Update core/src/client/async_client/mod.rs 

    Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
    @lexnv @TarikGul
    lexnv and TarikGul authored May 27, 2022
    Configuration menu
    Copy the full SHA
    24b5d67 View commit details
    Browse the repository at this point in the history

  3. Update core/src/client/async_client/mod.rs 

    Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
    @lexnv @TarikGul
    lexnv and TarikGul authored May 27, 2022
    Configuration menu
    Copy the full SHA
    839ec65 View commit details
    Browse the repository at this point in the history

  4. Update core/src/client/async_client/mod.rs 

    Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
    @lexnv @TarikGul
    lexnv and TarikGul authored May 27, 2022
    Configuration menu
    Copy the full SHA
    8a1462a View commit details
    Browse the repository at this point in the history

  5. Update core/src/client/async_client/mod.rs 

    Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
    @lexnv @TarikGul
    lexnv and TarikGul authored May 27, 2022
    Configuration menu
    Copy the full SHA
    ba14af9 View commit details
    Browse the repository at this point in the history

  6. Update core/Cargo.toml 

    Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
    @lexnv @niklasad1
    lexnv and niklasad1 authored May 27, 2022
    Configuration menu
    Copy the full SHA
    b79c64f View commit details
    Browse the repository at this point in the history

  7. Update core/Cargo.toml 

    Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
    @lexnv @niklasad1
    lexnv and niklasad1 authored May 27, 2022
    Configuration menu
    Copy the full SHA
    e615af5 View commit details
    Browse the repository at this point in the history

  8. logs: Keep debug log for submitting Ping frames 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 27, 2022
    Configuration menu
    Copy the full SHA
    baab48f View commit details
    Browse the repository at this point in the history

  9. Print debug logs when receiving Pong frames 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed May 27, 2022
    Configuration menu
    Copy the full SHA
    1738722 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Update core/src/client/async_client/mod.rs

    @niklasad1
    niklasad1 authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c661065 View commit details
    Browse the repository at this point in the history