fix(tracing): use tracing instrument macro #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Aug 3, 2022
niklasad1
commented
Aug 3, 2022
niklasad1
changed the title
lexnv
approved these changes
Aug 16, 2022
niklasad1
commented
Sep 15, 2022
… into na-use-tracing-instrument-macro
niklasad1
commented
Sep 15, 2022
niklasad1
commented
Sep 15, 2022
| @@ -267,7 +251,7 @@ pub(crate) async fn execute_call<L: Logger>(c: Call<'_, L>) -> MethodResult { | |||
|
|
|||
| let r = response.as_inner(); | |||
|
|
|||
| rx_log_from_str(&r.result, max_log_length); | |||
| tx_log_from_str(&r.result, max_log_length); | |||
niklasad1
commented
Sep 16, 2022
| fn execute_notification(notif: Notif, max_log_length: u32) -> MethodResponse { | ||
| rx_log_from_json(¬if, max_log_length); | ||
| let response = MethodResponse { result: String::new(), success: true }; | ||
| tx_log_from_str(&response.result, max_log_length); |
There was a problem hiding this comment.
this is silly it would just be an empty string but yeye for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #844
It relies on
instrumentmacro so we don't have to bother thinking about whether it's async or sync context :)I introduced a few bugs related that in the past and hopefully never again now