Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦀 Migrated project to Rust 🦀 #2

Merged
merged 32 commits into from
May 28, 2024
Merged

🦀 Migrated project to Rust 🦀 #2

merged 32 commits into from
May 28, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented May 23, 2024

This PR migrated the codebase to run in Rust.

Why?

Because I don't want to get rusty (🥁) and this action is small enough to test how the GitHub actions environment works in Rust.

This project uses actions-github as it's main dependency to obtain the metadata.

@Bullrich Bullrich self-assigned this May 23, 2024
@Bullrich Bullrich changed the title Migrated project to Rust 🦀 🦀 Migrated project to Rust 🦀 May 23, 2024
@Bullrich Bullrich marked this pull request as ready for review May 27, 2024 13:00
@Bullrich Bullrich requested a review from a team as a code owner May 27, 2024 13:00
Copy link

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Congrats with your first rust project :)
Dropped a couple of minor suggestions

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@Bullrich Bullrich enabled auto-merge (squash) May 28, 2024 12:13
@Bullrich Bullrich merged commit a8820fb into main May 28, 2024
12 checks passed
@Bullrich Bullrich deleted the rust/migration branch May 28, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants