crypto: Don't panic on unsupported key types #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that litep2p does not panic when decoding public keys from received TCP noise handshake.
The code operated under the assumption that only the
ed25519
key is valid in the context of Substrate.However, peers could still use a different key (
rsa
/ecdsa
) and cause the code to panic.In those cases, an error is returned which terminates the negotiation handshake.
Discovered during testing a sync node with litep2p backend on kusama as part of #83.
cc @dmitry-markin