Move storage keys computation to primitives #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Dec 17, 2021
acatangiu
added a commit
that referenced
this pull request
Dec 23, 2021
* Add `AtLeast32BitUnsigned` for MessageLance::SourceChainBalance (#1207) * Fix UI deployment. (#1211) * Remove unused PoA<>Substrate bridge (#1210) * Decouple the PoA bridge code from Rialto * Remove Rialto PoA bridge code * Remove relays/bin-ethereum code * Remove relays/client-ethereum code * Remove modules/ethereum code * Remove modules/ethereum-contract-builtin code * Remove PoA bridge documentation * Remove primitives/ethereum-poa code * Decouple Rialto from currency-exchange * Fix building with runtime-benchmarks * Fix should_encode_bridge_send_message_call test Because we removed some runtime modules/pallets, the substrate2substrate bridge pallet has a different index within the runtime so its calls have a different encoding. Update the test to use the new encoding. * Update readme - no more PoA bridge * Remove deployments/bridges/poa-rialto Also removes: - deployments/networks/eth-poa.yml - deployments/networks/OpenEthereum.Dockerfile * Remove deployments/dev/poa-config * Update deployments readme - no more PoA bridge * Remove eth-related scripts Deletes: - deployments/networks/eth-poa.yml - scripts/run-openethereum-node.sh * Remove poa-relay from gitlab-ci * Dockerfiles to use substrate-relay as default * Remove modules/currency-exchange code * Remove primitives/currency-exchange code Signed-off-by: acatangiu <adrian@parity.io> * Remove unused `relays/headers` (#1216) * Decouple `relays/client-substrate` from `headers_relay` * Remove `blocks_in_state` from `SyncLoopMetrics` This metric was only relevant for PoA <> Substrate bridge. * Move `sync_loop_metrics.rs` to `relays/finality` * Remove unused `SyncLoopMetrics::update()` * Hook up SyncLoopMetrics to finality_loop * Delete now unused `relays/headers` Signed-off-by: acatangiu <adrian@parity.io> * remove abandoned exchange relay (#1217) * Unify metric names (#1209) * unify metric names * refactor standalone metrics * headers sync metrics * post-merge fix * fix compilation * fmt * fix dashboards * fix local dashboards * update Rococo/Wococo runtime version * remove commented code * fixed grumbles * fmt * fixed widget names * Add CODEOWNERS file (#1219) * fixed set_operational in GRANDPA pallet (#1226) * Add mut support (#1232) * update dependencies (#1229) * Integrate BEEFY with Rialto & Millau runtimes (#1227) * Add Beefy pallet to Rialto runtime * Add Beefy gadget to Rialto node * Add MMR pallet to Rialto runtime * Add Beefy pallet to Millau runtime * Add Beefy gadget to Millau node * Add MMR pallet to Millau runtime * Add pallet_beefy_mmr to Millau runtime * Add pallet_beefy_mmr to Rialto runtime * Implement MMR and BEEFY APIs in Rialto * fix unit tests - should_encode_bridge_send_message_call() tests for new runtime encoding resulted from newly added pallets. - runtime size_of::<Call>() slightly increased from newly added pallets. * fix grumbles * tighten clippy allowances * fix more grumbles * Add MMR RPC to Rialto and Millau nodes Also implement MmrApi in Millau runtime. * rialto: use upstream polkadot_client::RuntimeApiCollection * Fix storage parameter name computation (#1238) * fixed storage_parameter_key * added test for storage_parameter_key * Enable Beefy debug logs in test deployment (#1237) Signed-off-by: Adrian Catangiu <adrian@parity.io> * Enable offchain indexing for Rialto/Millau nodes (#1239) * Enable off-chain indexing for Rialto & Millau nodes * cargo fmt --all * cargo +nightly fmt --all * fmt is weird. * Update Rococo/Wococo version + prepare relay for Rococo<>Wococo bridge (#1241) * update Rococo version + create relayers fund account * start finality relay guards when complex relay is started * Refactor finality relay helpers (#1220) * refactor finality relay helper definitions * add missing doc * removed commented code * fmt * disable rustfmt for macro * move best_finalized method const to relay chain def * Expose prometheus BEEFY metrics and add them to grafana dashboard (#1242) * deployments: expose node metrics Signed-off-by: acatangiu <adrian@parity.io> * deployments: add beefy grafana dashboard Signed-off-by: acatangiu <adrian@parity.io> * deployments: add beefy alarms Signed-off-by: acatangiu <adrian@parity.io> * Fix transactions mortality (#1196) * added lost stall timeout fix * use best_block.parent() to start mortal tx era * fmt * Revert "revert messages transactions mortality" This reverts commit 7777635. * post-merge build fix (#1243) * Refactor message relay helpers (#1234) * refactor message relay helpers * single standalone_metrics function * fixed tests * clippy + fmt * removed commented code * add calls tracing * fix spelling * cargo fmt * -commented code * fix build again * post-merge build fix * clippy + fmt * Use same endowed accounts set on dev/local chains (#1244) * use same accounts set on dev/local chains * run altruistic relayers in local demo scripts * runtimes: fix call_size() test (#1245) Signed-off-by: acatangiu <adrian@parity.io> * Bump relay version to 1.0.0 (#1249) * Add missing RPC APIs to rialto parachain node (#1250) * add missing RPC APIs to rialto parachain node * spellcheck * decrease startup sleep to 5s for relays and to 120s for generators + remove curl (#1251) * pin bridges-ci image (#1256) * Change submit transaction spec_version and transaction_version query from chain (#1248) * The `spec_version` and `transaction_version` query from chain * fix compile * Lint * Custom spec_version and transaction_version * runtime version params struct opt * runtime version cli * cli params * Add missing types defined * fix compile * debug cli * clippy * clippy * Query spec_version and transaction_version same times * Fix vars * Wrap option * Wrap option * Try fix ci * Change follow suggestions * remporary use pinned bridges-ci image in Dockerfile (#1258) * move storage keys computation to primitivs (#1254) * override conversion rate in estimate-message-fee RPC (#1189) * read latest_generated_nonce directly from storage (#1260) * bump rococo version (#1263) Co-authored-by: fewensa <37804932+fewensa@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com> Co-authored-by: Adrian Catangiu <31917973+acatangiu@users.noreply.github.com> Co-authored-by: Sergejs Kostjucenko <85877331+sergejparity@users.noreply.github.com> Co-authored-by: Antonio Dropulic <antonio@parity.io> Co-authored-by: Adrian Catangiu <adrian@parity.io>
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* adapt to common good paras * fmt * Updated to leave parachain-template alone * use norm_id + cargo fmt * removed comment as we are not touching parachain template * is_penpal * updated code to new locations * changes required to get penpal running * cargo fmt * remove warning, rename chain * Update polkadot-parachain/src/command.rs * Update polkadot-parachain/src/command.rs Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> * remove now moved functions * added runtime description * add missing copyright notices * more copyright notices. Co-authored-by: NachoPal <ignacio.palacios.santos@gmail.com>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required both for #1218 and for #1246. I've replaced a set of similar
storage_map_final_key_*functions with single generic + moved all storage keys computations to primitives of corresponding pallets + added some more tests to make sure versions won't diverge.