Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark Ethereum Pallet #149
Benchmark Ethereum Pallet #149
Changes from all commits
ff61e17
bdeb817
765ed91
0201c8c
5b87f54
6ff214c
c4131e3
e2b3461
b345e94
199c925
92a845d
d464d07
4475995
92c1bf0
4174441
fdb126f
a8e6c56
c032a96
044b2e2
ca5c1f2
b21d07a
751929e
d5eab22
1c85d7b
51245da
a6517ae
f8ddaef
029d966
33035d1
777500a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing I forgot to add to my top-level comment - imo
weight(import_signed_headers)
is actuallyweight(import_unsigned_header) * len(headers) + some_constant
, wheresome_constant
stands for recovering signature + iterating headers + invoking callbacks (which are noop in our runtime - not sure how to measure that in general case?). So we may only introduce benchmarks for unsigned version and use results for signed version.