Fixed best_ethereum_block() call parameters encoding #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Jul 14, 2020
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* fixed best_ethereum_block() params encoding * updated versions
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* fixed best_ethereum_block() params encoding * updated versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits - first one is actually fixing issue - it changes runtime call params from
Bytes("0x".into())toBytes(Vec::new()). Seems like there has been recent decoding-related change that has lead to'Bad input data provided to best_block: Input buffer has still data left after decoding!'in cases when params buffer has extra data.The second one is about updating/fixing references. I've changed that while trying to debug issue: (1) I've added missing
tag = 'v2.0.0-rc4'to build dependencies and (2) changed explicit codec references to 1.3.1 in toml files (Cargo.lockwas already pointing to that version). This is optional commit - seems that it affects nothing, but imo it is still helpful. Can revert on demand.