Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to polkadot-staging: Deduplicate Grandpa consensus log reading logic (#2245) #2246

Merged

Conversation

serban300
Copy link
Collaborator

No description provided.

@serban300 serban300 self-assigned this Jul 7, 2023
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO better not to touch polkadot-staging without significant reasons - like bug fixes or absolutely required refactorings. But this change is small enough, so let's merge.

@serban300
Copy link
Collaborator Author

IMO better not to touch polkadot-staging without significant reasons - like bug fixes or absolutely required refactorings. But this change is small enough, so let's merge.

Agree. Just merging it to make sure we won't have conflicts when fixing #2496.

@serban300 serban300 merged commit 0b46956 into paritytech:polkadot-staging Jul 7, 2023
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
serban300 added a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 added a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants