-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate constants for average and worst case relay headers #2728
Merged
svyatonik
merged 2 commits into
polkadot-staging
from
separate-consts-for-average-and-worst-header-size
Dec 5, 2023
Merged
separate constants for average and worst case relay headers #2728
svyatonik
merged 2 commits into
polkadot-staging
from
separate-consts-for-average-and-worst-header-size
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you need to add WORST_HEADER_SIZE_IN_JUSTIFICATION
to the polkadot-bulletin
imports
pub use bp_polkadot_core::{
AccountAddress, AccountId, Balance, Block, BlockNumber, Hash, Hasher, Header, Nonce, Signature,
SignedBlock, UncheckedExtrinsic, AVERAGE_HEADER_SIZE_IN_JUSTIFICATION,
EXTRA_STORAGE_PROOF_SIZE, MAX_HEADER_SIZE, REASONABLE_HEADERS_IN_JUSTIFICATON_ANCESTRY,
};
svyatonik
deleted the
separate-consts-for-average-and-worst-header-size
branch
December 5, 2023 15:00
3 tasks
bkontur
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Dec 6, 2023
## Summary This PR aligns Rococo/Westend bridge with latest Bridges repo development: - paritytech/parity-bridges-common#2727 - paritytech/parity-bridges-common#2728 - paritytech/parity-bridges-common#2729 Part of: paritytech/parity-bridges-common#2452
svyatonik
added a commit
that referenced
this pull request
Dec 8, 2023
* separate constants for average and worst case relay headers * fix compilation
svyatonik
added a commit
that referenced
this pull request
Dec 8, 2023
* separate constants for average and worst case relay headers (#2728) * separate constants for average and worst case relay headers * fix compilation * Select header that will be fully refunded in on-demand batch finality relay (#2729) * select header that will be fully refunded for submission in on-demand **batch** finality relay * added the only possible test * spelling * nl * updated comment * backport some nits from #2727 * NotApplicable instead of Unroutable * Grafana update stuff (#2733) --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…ch#2728) * separate constants for average and worst case relay headers * fix compilation
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…ch#2728) * separate constants for average and worst case relay headers * fix compilation
bkontur
added a commit
that referenced
this pull request
May 7, 2024
* separate constants for average and worst case relay headers (#2728) * separate constants for average and worst case relay headers * fix compilation * Select header that will be fully refunded in on-demand batch finality relay (#2729) * select header that will be fully refunded for submission in on-demand **batch** finality relay * added the only possible test * spelling * nl * updated comment * backport some nits from #2727 * NotApplicable instead of Unroutable * Grafana update stuff (#2733) --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to move bridge fees towards expected after paritytech/polkadot-sdk#2139 . There I've used existing
AVERAGE_HEADER_SIZE_IN_JUSTIFICATION
constants, which are actually worst possible header size. Once this PR is merged, we'll keep using worst possible const for computing maximal refund, but for computing fees we'll be using average header size. Side effects:FEE
;MaxFEE
, which is larger than theFEE
;MaxFEE - FEE
will be paid by the SA of AH.In real world, however, we'll be running our own realyer (at least for v1), which is configured to deliver messages/confirmations asap and will select the header without looking at its size. Since we expect headers to have the
AVERAGE_HEADER_SIZE_IN_JUSTIFICATION
, not theWORST_HEADER_SIZE_IN_JUSTIFICATION
. So the actual fee in average will be closer to theFEE
, not theMaxFEE
.