Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume migrated crates from polkadot-sdk #2921

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

serban300
Copy link
Collaborator

@serban300 serban300 commented Apr 10, 2024

Related to #2538

Remove the migrated crates and consume them from polkadot-sdk

@serban300 serban300 self-assigned this Apr 10, 2024
@serban300 serban300 requested a review from a team as a code owner April 10, 2024 10:51
@@ -121,7 +121,7 @@ check:
<<: *docker-env
<<: *test-refs
script: &check-script
- SKIP_WASM_BUILD=1 time cargo check --locked --verbose --workspace --features runtime-benchmarks
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove --features runtime-benchmarks because none of the remaining crates expose such a feature anymore.

@serban300 serban300 changed the title Remove migrated crates Consume migrated crates from polkadot-sdk Apr 10, 2024
Copy link
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only -54k lines 😆

@serban300 serban300 merged commit a174cfa into paritytech:polkadot-staging Apr 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants