[plain_hasher] Migrate to 2018 edition #213
Conversation
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
.travis.yml
Outdated
| @@ -34,7 +34,7 @@ script: | |||
| fi | |||
| - cd fixed-hash/ && cargo test --all-features && cd .. | |||
| - cd uint/ && cargo test --features=std,quickcheck --release && cd .. | |||
| - cd plain_hasher/ && cargo test --no-default-features && cd .. | |||
| - cd plain_hasher/ && cargo test --no-default-features && cargo test --benches && cd .. | |||
There was a problem hiding this comment.
| - cd plain_hasher/ && cargo test --no-default-features && cargo test --benches && cd .. | |
| - cd plain_hasher/ && cargo test --no-default-features && cargo check --benches && cd .. |
There was a problem hiding this comment.
It just my personal convention. cargo test --benches is building all benchmarkable targets and running them as tests.
There was a problem hiding this comment.
cargo test --benches runs tests as well. And it seems it actually runs the benches. So that's not what we want here right?
There was a problem hiding this comment.
Actually, it runs the benchmarks like that (include running unit-tests):
running 1 test
test tests::it_works ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
...
Testing write_plain_hasher
Success
Testing write_default_hasher
Success
There was a problem hiding this comment.
Right, and we do not wish to run the benchmarks on CI.
(Not that it's a bad thing per se to run the benches, but it's not worth anything if we don't collect the output performance data and store it somewhere, and we're not so for the time being running the benches just slows CI down for no benefit.)
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
@koushiro please merge with master |
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
.travis.yml
Outdated
| @@ -34,7 +34,7 @@ script: | |||
| fi | |||
| - cd fixed-hash/ && cargo test --all-features && cd .. | |||
| - cd uint/ && cargo test --features=std,quickcheck --release && cd .. | |||
| - cd plain_hasher/ && cargo test --no-default-features && cd .. | |||
| - cd plain_hasher/ && cargo test --no-default-features && cargo test --benches && cd .. | |||
There was a problem hiding this comment.
cargo test --benches runs tests as well. And it seems it actually runs the benches. So that's not what we want here right?
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
* master: [plain_hasher] Migrate to 2018 edition (#213) [ethbloom] Improve ethbloom (#215) [rlp] fix nested unbounded lists (#203) stabilize parity-bytes in no_std environment (#212) Speed up hex serialization, support Serde `with`, and fix warnings (#208) [ethbloom, ethereum-types,kvdb] migrate to 2018 edition (#205) Introduce `ContractAddress` newtype instead of scheme enum (#200)
What I have changed
plain_hashercrate to 2018 edition (related issue: Migrate all crates to 2018 edition #143)libtestwithcriterion