chore(deps): cargo upgrade parking_lot --all

[niklasad1]

Fixes #469

[ordian]

That's a breaking change for parity-util-mem worth mentioning in the changelog. Also worth upgrading it other deps.

[ordian]

don't know what's up with kvdb-web firefox tests...

[niklasad1]

don't know what's up with kvdb-web firefox tests...

I get this locally:

[INFO]: Installing wasm-bindgen...
[INFO]: Getting geckodriver...
    Finished test [unoptimized + debuginfo] target(s) in 0.06s
     Running /../wasm32-unknown-unknown/debug/deps/kvdb_web-27dddb4ab137979f.wasm
no tests to run!
     Running /../parity-common/target/wasm32-unknown-unknown/debug/deps/indexed_db-5e1d85d25129b5dc.wasm
Running headless tests in Firefox on `http://127.0.0.1:45825/`
Try find `webdriver.json` for configure browser's capabilities:
Not found
driver status: signal: 9
driver stdout:
    1607335240730       geckodriver     INFO    Listening on 127.0.0.1:45825

Error: non-200 response code: 500
{"value":{"error":"unknown error","message":"Invalid Content-Type","stacktrace":""}}
error: test failed, to rerun pass '--test indexed_db'
Error: Running Wasm tests with wasm-bindgen-test failed
Caused by: failed to execute `cargo test`: exited with exit code: 1
  full command: "cargo" "test" "--target" "wasm32-unknown-unknown"

[dvdplm]

Suggested change

	- Updated dependencies. [#470](https://github.com/paritytech/parity-common/pull/470)
	- Updated dependencies, notably `parking_lot`. [#470](https://github.com/paritytech/parity-common/pull/470)

Maybe?

[niklasad1]

@ordian

The failed test for kvdb-web seems legit which doesn't occur on master on machine.
I get the following:

     Running /.../target/wasm32-unknown-unknown/debug/deps/indexed_db-1ff3367933372b08.wasm
Set timeout to 20 seconds...
Running headless tests in Firefox on `http://127.0.0.1:44947/`
Try find `webdriver.json` for configure browser's capabilities:
Not found
Failed to detect test as having been run. It might have timed out.
output div contained:
    Loading scripts...

driver status: signal: 9
driver stdout:
    1607425910385       geckodriver     INFO    Listening on 127.0.0.1:44947
    1607425910487       mozrunner::runner       INFO    Running command: "/usr/bin/firefox" "--marionette" "-headless" "-foreground" "-no-remote" "-profile" "/tmp/rust_mozprofileTY46vd"
    console.warn: SearchSettings: "get: No settings file exists, new profile?" (new Error("", "(unknown module)"))
    1607425911447       Marionette      INFO    Listening on port 34331
    1607425931707       Marionette      INFO    Stopped listening on port 34331

driver stderr:
    *** You are running in headless mode.
    JavaScript error: http://127.0.0.1:40089/wasm-bindgen-test, line 1: TypeError: Error resolving module specifier “env”. Relative module specifiers must start with “./”, “../” or “/”.

Error: some tests failed
error: test failed, to rerun pass '--test indexed_db'
Error: Running Wasm tests with wasm-bindgen-test failed
Caused by: failed to execute `cargo test`: exited with exit code: 1
  full command: "cargo" "test" "--target" "wasm32-unknown-unknown"

Do you have a clue what's going on there?

[ordian]

Yeah, seems like rustwasm/wasm-pack#726.
I was able to make it work by enabling wasm-bindgen feature of parking_lot: https://github.com/Amanieu/parking_lot/blob/14448584352ac3aa3fbec4f9d8a80d4799e5b90e/Cargo.toml#L31, although in a hacky way. We could maybe add this feature to kvdb-memory, dunno.

[niklasad1]

This is required because of https://github.com/Amanieu/parking_lot/blob/37ceeb36a1b0ef9cc0176ef0c9e35b8562002656/Cargo.toml#L31

[niklasad1]

FYI, I didn't add this to:

• parity-util-memory because it's an optional dependency
• kvdb-rocksdb because it doesn't compile for WASM

[ordian]

This is not ideal, because we'd want to eventually get rid of kvdb-memory from kvdb-web, but that would require making kvdb async.
What will likely happen is that kvdb-web will be deprecated (I think it's no longer used already?) in favor of what substrate-lite uses (based on localStorage?). And this feature of kvdb-memorydb will become useless.

However, I think kvdb-memorydb is mostly used for tests, so it's fine I guess ¯_(ツ)_/¯

[niklasad1]

ok, we could do another super ugly hack, just to bring in parking_lot as a dependency in kvd-web with the wasm-bindgen feature then we don't have to have it in kvdb-memory because of how features work.

[ordian]

yeah, that's what I did when I wrote

although in a hacky way

I think it's fine as is though. kvdb-memorydb could be in theory used in a wasm-bindgen environment

[dvdplm]

just to bring in parking_lot as a dependency in kvd-web with the wasm-bindgen feature then we don't have to have it in kvdb-memory because of how features work.

This is terrible but let's do it anyway. We need a fat-ass comment in kvdb-web/Cargo.toml reminding us why it's here and to get rid of it as soon as possible.

[ordian]

@dvdplm let's get this reviewed and merged, so that we can unblock the release process for a bunch of crates after we upgrade other dependencies as well

[niklasad1]

@dvdplm sufficient?

[dvdplm]

Perfect.